OPRUN-4057: Migrate single/own namespace tests #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@camilamacedo86: This pull request references OPRUN-4057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
single-add-ote
branch
2 times, most recently
from
fc79ef4 to
0b054e2
Compare
camilamacedo86
commented
Aug 8, 2025
| @@ -1,4 +1,34 @@ | |||
| [ | |||
| { | |||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for singleNamespace watch mode with quay-operator should install a cluster extension successfully", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
We should add SERIAL in the names, but they are not today
We properly renamed the test tracking both over the time
camilamacedo86
commented
Aug 8, 2025
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with quay-operator should install a cluster extension successfully", |
There was a problem hiding this comment.
There was a problem hiding this comment.
We should add SERIAL in the names, but they are not today
We properly renamed the test tracking both over the time
camilamacedo86
commented
Aug 8, 2025
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with an operator that does not support ownNamespace installation mode should fail to install a cluster extension successfully", |
There was a problem hiding this comment.
There was a problem hiding this comment.
We should add SERIAL in the names, but they are not today
We properly renamed the test tracking both over the time
camilamacedo86
force-pushed
the
single-add-ote
branch
2 times, most recently
from
c51fde3 to
4c028b6
Compare
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
camilamacedo86
commented
Aug 11, 2025
| @@ -1,4 +1,34 @@ | |||
| [ | |||
| { | |||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected][Serial] OLMv1 operator installation support for singleNamespace watch mode with quay-operator should install a cluster extension successfully", | |||
There was a problem hiding this comment.
We should add SERIAL in the names, but they are not today
We properly renamed the test tracking both over the time
openshift-ci
bot
added
the
do-not-merge/hold
camilamacedo86
force-pushed
the
single-add-ote
branch
from
4c028b6 to
21ea6a8
Compare
|
@camilamacedo86: This pull request references OPRUN-4057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
force-pushed
the
single-add-ote
branch
2 times, most recently
from
dec72bb to
3913bae
Compare
|
/test e2e-aws-techpreview-olmv1-ext |
camilamacedo86
force-pushed
the
single-add-ote
branch
from
3913bae to
72f970b
Compare
|
/test e2e-aws-techpreview-olmv1-ext |
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
single-add-ote
branch
from
72f970b to
e133b0a
Compare
|
/retest-required |
camilamacedo86
force-pushed
the
single-add-ote
branch
2 times, most recently
from
e87c877 to
7dbc583
Compare
camilamacedo86
force-pushed
the
single-add-ote
branch
from
654a096 to
618861d
Compare
|
@camilamacedo86: This pull request references OPRUN-4057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@camilamacedo86: This pull request references OPRUN-4057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-aggregate periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn-techpreview-serial 10 |
|
@camilamacedo86: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fa4a1a60-7dad-11f0-856b-9bcfe9c1c15c-0 |
|
@camilamacedo86: This pull request references OPRUN-4057 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold Just waiting finish :https://pr-payload-tests.ci.openshift.org/runs/ci/fa4a1a60-7dad-11f0-856b-9bcfe9c1c15c-0 |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This commit migrates the OLMv1 single and own namespace watch mode tests from openshift/origin/test/extended/olm/olmv1-singleownnamespace.go to this repository. This is part of the effort to move component-specific tests into their respective downstream locations. Assisted-by: Gemini
camilamacedo86
force-pushed
the
single-add-ote
branch
from
618861d to
0174327
Compare
|
@camilamacedo86: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@tmshort could you give a hand in this one? See that was tested with aggregate as well: |
tmshort
reviewed
Aug 21, 2025
Comment on lines
+72
to
+110
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected][Serial] OLMv1 operator installation support for singleNamespace watch mode with quay-operator should install a cluster extension successfully", | ||
| "originalName": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for singleNamespace watch mode with quay-operator should install a cluster extension successfully", | ||
| "labels": { | ||
| "original-name:[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for singleNamespace watch mode with quay-operator should install a cluster extension successfully": {} | ||
| }, | ||
| "resources": { | ||
| "isolation": {} | ||
| }, | ||
| "source": "openshift:payload:olmv1", | ||
| "lifecycle": "blocking", | ||
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected][Serial] OLMv1 operator installation support for ownNamespace watch mode with quay-operator should install a cluster extension successfully", | ||
| "originalName": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with quay-operator should install a cluster extension successfully", | ||
| "labels": { | ||
| "original-name:[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with quay-operator should install a cluster extension successfully": {} | ||
| }, | ||
| "resources": { | ||
| "isolation": {} | ||
| }, | ||
| "source": "openshift:payload:olmv1", | ||
| "lifecycle": "blocking", | ||
| "environmentSelector": {} | ||
| }, | ||
| { | ||
| "name": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected][Serial] OLMv1 operator installation support for ownNamespace watch mode with an operator that does not support ownNamespace installation mode should fail to install a cluster extension successfully", | ||
| "originalName": "[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with an operator that does not support ownNamespace installation mode should fail to install a cluster extension successfully", | ||
| "labels": { | ||
| "original-name:[sig-olmv1][OCPFeatureGate:NewOLMOwnSingleNamespace][Skipped:Disconnected] OLMv1 operator installation support for ownNamespace watch mode with an operator that does not support ownNamespace installation mode should fail to install a cluster extension successfully": {} | ||
| }, | ||
| "resources": { | ||
| "isolation": {} | ||
| }, | ||
| "source": "openshift:payload:olmv1", | ||
| "lifecycle": "blocking", | ||
| "environmentSelector": {} | ||
| }, |
There was a problem hiding this comment.
So, you made these all Serial?
There was a problem hiding this comment.
They were serial but were missing the Serial in the name
|
/lgtm |
openshift-merge-bot
bot
merged commit 2ed1a5c
into
openshift:main
12 of 13 checks passed
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-operator-controller |
|
[ART PR BUILD NOTIFIER] Distgit: ose-olm-catalogd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates the OLMv1 single and own namespace watch mode tests from openshift/origin/test/extended/olm/olmv1-singleownnamespace.go to this repository. This is part of the effort to move component-specific tests into their respective downstream locations.
PS.: See that we need to name the tests to add [Serial]
Tests
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fa4a1a60-7dad-11f0-856b-9bcfe9c1c15c-0